doc: add missing environment variables to manpage and remove test wor… #58924
Conversation
There was a problem hiding this comment.
Thank you very much for the PR @HumaneLogic 🎉
I've left a few small comments but overall looks good to me 🙂
PS: the commit message needs to be shortened (as I mentioned in the issue)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58924 +/- ##
==========================================
- Coverage 90.11% 90.10% -0.01%
==========================================
Files 640 640
Lines 188427 188427
Branches 36956 36962 +6
==========================================
- Hits 169792 169781 -11
- Misses 11348 11349 +1
- Partials 7287 7297 +10 🚀 New features to boost your workflow:
|
|
im sorry it took too long ,i'm gonna fix them right now |
No problem there's no rush 🙂 The commit still needs to be fixed, could you please rebase, squash the two commits into one and update the commit message? 🙂 |
…karound test: remove fallback for missing manpage env vars
|
…karound test: remove fallback for missing manpage env vars test: remove fallback for missing manpage env vars
|
@dario-piotrowicz i made a new pull request, i had problems with squashing, i created a new PR #58963 |
|
Closing as per the above comment |
3 participants
Fixes: #58894