Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: remove target size for CTC #5879

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 23, 2016

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

doc

Description of change

CTC target size of 6 to 12 seems out of date. Proposing increase to 9 to 15.

Refs: #5866

@Trott Trott added doc Issues and PRs related to the documentations. ctc-agenda labels Mar 23, 2016
@ChALkeR
Copy link
Member

ChALkeR commented Mar 23, 2016

is between 9 and 15

But there are 18 now.

@Trott
Copy link
Member Author

Trott commented Mar 23, 2016

@ChALkeR Right. My thinking was: It's a target size, not an upper limit. Go for a modest, incremental move in the right direction.

If there's consensus around between 9 and 18, I wouldn't object. I was just trying to be conservative. After all, we can always modify it again later.

@jbergstroem
Copy link
Member

The lower boundary of "50% group attendance" for consensus makes sense to me. My LGTM probably doesn't matter here, but I think this is the right approach.

However, the expected target is between 6 and 12, to ensure adequate
coverage of important areas of expertise, balanced with the ability to
However, the expected target is between 9 and 15 to ensure adequate
coverage of important areas of expertise balanced with the ability to
make decisions efficiently.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just take the bound out entirely...

CTC seats are not time-limited. While there is no fixed size of the CTC,
it is expected to contain adequate membership to ensure coverage of 
important areas of expertise with the ability to make decisions efficiently.

@jasnell jasnell added the meta Issues and PRs related to the general management of the project. label Mar 23, 2016
@Trott
Copy link
Member Author

Trott commented Mar 24, 2016

Based on @jasnell's suggestion, I removed the material about size of the CTC entirely. PTAL

@jasnell
Copy link
Member

jasnell commented Mar 24, 2016

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Mar 24, 2016

LGTM

@bnoordhuis
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented Mar 27, 2016

@nodejs/ctc

@indutny
Copy link
Member

indutny commented Mar 27, 2016

LGTM

@@ -64,10 +64,6 @@ A guide for Collaborators is maintained in
## CTC Membership

CTC seats are not time-limited. There is no fixed size of the CTC.
However, the expected target is between 6 and 12, to ensure adequate
coverage of important areas of expertise, balanced with the ability to
make decisions efficiently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Would keep in the

(Attempts to) ensure adequate coverage of important areas of expertise, balanced with the ability to make decisions efficiently.

Or something of the like.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fishrock123 If others agree strongly with that, then sure. I took it out for three reasons, from least important to most important:

  • All other things being equal, less text is better than more.
  • I feel like what's stated there is a given and so doesn't need to be stated explicitly. Of course we're looking to cover all important areas of expertise. Of course we want to be able to operate efficiently.
  • I also want to avoid the possible misunderstanding that things listed there are the only factors to be considered. Let's imagine the CTC were hypothetically composed of only Americans in San Francisco, Austin, and New York. Even if all areas of expertise were covered, and even if it hampers operational efficiency, it would (in this purely hypothetical situation) be worthwhile to seek out voices from other parts of the world. But that's not covered (or at least it isn't if you infer "important areas of expertise" to be strictly technical, which I suspect most readers do).

So those were my reasons, but again, if others feel strongly that it ought to remain, then that's fine. There are other considerations and that one sentence of text is not something I want to have a prolonged discussion about, certainly not at this time when all I'm really trying to do is fix the number of members part.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like what's stated there is a given and so doesn't need to be stated explicitly. Of course we're looking to cover all important areas of expertise. Of course we want to be able to operate efficiently.

If it's not stated, it becomes assumptions. I don't have an immediate suggestion on how to make it better though, other than also covering "use-cases".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

There is no fixed size of the CTC. The goal is to ensure
adequate coverage of important areas of expertise and
diversity of representation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's always the option of some "including, but not limited to, X, Y, and Z" language....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm restoring the original language and just removing the part about target size. We can alter the original language, I suppose, but hopefully it can be agreed that that would be a separate issue from simply removing the target sizes.

@Trott
Copy link
Member Author

Trott commented Mar 30, 2016

I've restored some text that @Fishrock123 and perhaps others thought shouldn't be removed. Effectively, this now only removes the target size information. If I can get a few LGTMs (repeat or new), that would be swell.

coverage of important areas of expertise, balanced with the ability to
make decisions efficiently.
CTC seats are not time-limited. There is no fixed size of the CTC. The CTC
should be of such a size as to ensure adequate coverage of important areas of
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... should be of such a size and diversity to ensure... ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to add diversity as a consideration, I support that. But it was not in the original text and I think it should go in as a separate PR. This PR is for getting rid of the obsolete target size.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@jasnell
Copy link
Member

jasnell commented Mar 30, 2016

LGTM with a minor nit.

@Trott Trott changed the title governance: increase target size for CTC governance: remove target size for CTC Mar 30, 2016
@mhdawson
Copy link
Member

LGTM

1 similar comment
@evanlucas
Copy link
Contributor

LGTM

@Trott Trott removed the ctc-agenda label Mar 30, 2016
@Trott
Copy link
Member Author

Trott commented Mar 30, 2016

Landed in bb28770

@Trott Trott closed this Mar 30, 2016
Trott added a commit that referenced this pull request Mar 30, 2016
PR-URL: #5879
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
PR-URL: #5879
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
PR-URL: #5879
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
PR-URL: #5879
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
@Trott Trott deleted the upto9 branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.