test: fix test-debugger-client.js #5851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix long-broken test-debugger-client by adding missing `\r\n\r\n` separator.
|
LGTM if it fixes the problem |
|
CI (although this code is not exercised by CI beyond linting): https://ci.nodejs.org/job/node-test-pull-request/2031/ |
|
On CI, ARM failure is unrelated, will fix in a separate PR. Those pi1 devices have sure started to hate on those tests with arbitrary timeouts. |
|
LGTM.. tho it's not an area I'm too familiar with |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 24, 2016
Fix long-broken test-debugger-client by adding missing `\r\n\r\n` separator. PR-URL: nodejs#5851 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in fc8542f |
evanlucas
pushed a commit
that referenced
this pull request
Mar 30, 2016
Fix long-broken test-debugger-client by adding missing `\r\n\r\n` separator. PR-URL: #5851 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Mar 31, 2016
Fix long-broken test-debugger-client by adding missing `\r\n\r\n` separator. PR-URL: #5851 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 8, 2016
Fix long-broken test-debugger-client by adding missing `\r\n\r\n` separator. PR-URL: #5851 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test, debugger
Description of change
Fix long-broken test-debugger-client by adding missing
\r\n\r\nseparator.
/cc @nodejs/testing