benchmark: fix linting errors #5840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d78121 had lint errors that went undetected. This fixes them.
Trott
added
benchmark
|
Since CI is broken until this lands, and these changes are tiny, a fast turnaround would be much appreciated. /cc @nodjes/collaborators |
|
LGTM |
|
LGTM... tested locally |
|
LGTM |
|
Will get it landed |
jasnell
pushed a commit
that referenced
this pull request
Mar 22, 2016
4d78121 had lint errors that went undetected. This fixes them. PR-URL: #5840 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in cde81b6 |
|
Retroactive CI: https://ci.nodejs.org/job/node-test-pull-request/2008/ |
|
ran make lint on this before landing ;-) |
|
Linting passed at least: https://ci.nodejs.org/job/node-test-linter/1757/ :-P |
|
7 minutes from proposed to landed. This might be the fastest PR merge of the post-BDFL era. |
|
heh... looks like I shouldn't land pull requests while distracted. I must have completely missed running make lint locally on several PRs in a row. More automation would be good. I need to get the PR landing tool finished up. |
Fishrock123
pushed a commit
that referenced
this pull request
Mar 22, 2016
4d78121 had lint errors that went undetected. This fixes them. PR-URL: #5840 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
benchmark
Description of change
4d78121 had lint errors that went
undetected. This fixes them.