Skip to content

Free req.file.pathw in fs::ReadFileUtf8(). #57811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Free req.file.pathw in fs::ReadFileUtf8(). #57811

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a00fc51
fs: add missing call to uv_fs_req_cleanup
Justin-Nietzel Apr 9, 2025
951437d
fs: added test for missing call to uv_fs_req_cleanup
Justin-Nietzel Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2711,10 +2711,10 @@ static void ReadFileUtf8(const FunctionCallbackInfo<Value>& args) {
FS_SYNC_TRACE_END(open);
if (req.result < 0) {
uv_fs_req_cleanup(&req);
// req will be cleaned up by scope leave.
return env->ThrowUVException(
static_cast<int>(req.result), "open", nullptr, path.out());
}
uv_fs_req_cleanup(&req);
}

auto defer_close = OnScopeLeave([file, is_fd, &req]() {
Expand Down
Loading