Skip to content

src: remove unused variable in crypto_x509.cc #57754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

src: remove unused variable in crypto_x509.cc #57754

merged 1 commit into from
Apr 5, 2025

Conversation

@targos
Copy link
Member

@targos targos commented Apr 5, 2025

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 5, 2025
@targos
Copy link
Member Author

targos commented Apr 5, 2025

Not sure how it wasn't caught, but here is the error I get in an unrelated PR: https://github.com/nodejs/node/actions/runs/14280449557/job/40029374410

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2025

Fast-track has been requested by @targos. Please 👍 to approve.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 5, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66041/

@codecov
Copy link

codecov bot commented Apr 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (e739559) to head (a7f1c42).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57754      +/-   ##
==========================================
- Coverage   90.26%   90.25%   -0.01%     
==========================================
  Files         630      630              
  Lines      185181   185180       -1     
  Branches    36281    36279       -2     
==========================================
- Hits       167147   167142       -5     
- Misses      10995    10996       +1     
- Partials     7039     7042       +3
Files with missing lines Coverage Δ
src/crypto/crypto_x509.cc 70.44% <ø> (-0.05%) ⬇️

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66044/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit fb26fa1 into nodejs:main Apr 5, 2025
76 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fb26fa1

@targos targos deleted the rm-unused-x509 branch April 5, 2025 15:32
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@targos @JonasBa
src: remove unused variable in crypto_x509.cc
4d20b88 
PR-URL: nodejs#57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@targos @RafaelGSS
src: remove unused variable in crypto_x509.cc
23cc162 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@targos @RafaelGSS
src: remove unused variable in crypto_x509.cc
db8b29d 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@targos @aduh95
src: remove unused variable in crypto_x509.cc
216c268 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@targos @RafaelGSS
src: remove unused variable in crypto_x509.cc
25da922 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@targos @aduh95
src: remove unused variable in crypto_x509.cc
86a4d80 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@targos @aduh95
src: remove unused variable in crypto_x509.cc
962496d 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@targos @aduh95
src: remove unused variable in crypto_x509.cc
92760ae 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@targos @aduh95
src: remove unused variable in crypto_x509.cc
8ac9345 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@targos @aduh95
src: remove unused variable in crypto_x509.cc
bec053a 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@targos @marco-ippolito
src: remove unused variable in crypto_x509.cc
9bd583a 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@targos @marco-ippolito
src: remove unused variable in crypto_x509.cc
5480c73 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jun 5, 2025
Merged
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
@targos @marco-ippolito
src: remove unused variable in crypto_x509.cc
f004ccc 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
@targos @marco-ippolito
src: remove unused variable in crypto_x509.cc
d582954 
PR-URL: #57754
Reviewed-By: Tim Perry <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

@lpinca lpinca lpinca approved these changes

@pimterry pimterry pimterry approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

+1 more reviewer

@mertcanaltin mertcanaltin mertcanaltin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@targos @nodejs-github-bot @panva @lpinca @pimterry @anonrig @richardlau @mertcanaltin