test: reduce brittleness of tab complete test #5772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiorodriguez
added
repl
| putIn.run(['.clear']); | ||
| putIn.run(['var obj = {1:"a","1a":"b",a:"b"};']); | ||
|
|
||
| testMe.complete('obj.', common.mustCall(function(error, data) { | ||
| assert.deepEqual(data, obj_elements); | ||
| assert.equal(data[0].indexOf('obj.1'), -1); | ||
| assert.equal(data[0].indexOf('obj.1a'), -1); | ||
| })); |
There was a problem hiding this comment.
Nit: maybe also check that obj.a is there.
|
LGTM if CI is green. Left a nit that you can ignore if you want. |
|
I'd prefer strict equality checks in the test, but other than that, LGTM pending CI. |
test-repl-tab-complete includes tests that ensure that certain keys do not appear in tab completions or that completion does not crash the repl. It performed these tests by comparing completion output to a hardcoded list of expected keys. This list is made incorrect by any api changes that occur when new versions of V8 are introduced. With this change, we assert that the specific keys to be avoided are not present in the output instead.
|
@cjihrig Done. |
|
Failures on smartos14-64 seem unrelated. |
|
LGTM |
|
Re-running CI for SmartOS: https://ci.nodejs.org/job/node-test-commit-smartos/1758/ |
|
CI is green |
jasnell
pushed a commit
that referenced
this pull request
Mar 19, 2016
test-repl-tab-complete includes tests that ensure that certain keys do not appear in tab completions or that completion does not crash the repl. It performed these tests by comparing completion output to a hardcoded list of expected keys. This list is made incorrect by any api changes that occur when new versions of V8 are introduced. With this change, we assert that the specific keys to be avoided are not present in the output instead. PR-URL: #5772 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 0eb3ed5 |
Fishrock123
pushed a commit
that referenced
this pull request
Mar 22, 2016
test-repl-tab-complete includes tests that ensure that certain keys do not appear in tab completions or that completion does not crash the repl. It performed these tests by comparing completion output to a hardcoded list of expected keys. This list is made incorrect by any api changes that occur when new versions of V8 are introduced. With this change, we assert that the specific keys to be avoided are not present in the output instead. PR-URL: #5772 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Conflicts: test/parallel/test-repl-tab-complete.js
|
This change relies on semver major changes... going to change to don't land for now, but open to it if someone wants to backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Affected core subsystem(s)
Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)
test
Description of change
Please provide a description of the change here.
test-repl-tab-complete includes tests that ensure that certain keys do
not appear in tab completions or that completion does not crash the
repl. It performed these tests by comparing completion output to a
hardcoded list of expected keys. This list is made incorrect by any api
changes that occur when new versions of V8 are introduced.
With this change, we assert that the specific keys to be avoided are
not present in the output instead.