Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asyncwrap more #5756

Merged
merged 5 commits into from
Mar 28, 2016
Merged

Asyncwrap more #5756

merged 5 commits into from
Mar 28, 2016

Commits on Mar 28, 2016

  1. src,http_parser: remove KickNextTick call 

    Now that HTTPParser uses MakeCallback it is unnecessary to manually
process the nextTickQueue.

The KickNextTick function is now no longer needed so code has moved back
to node::MakeCallback to simplify implementation.

Include minor cleanup moving Environment::tick_info() call below the
early return to save an operation.

PR-URL: nodejs#5756
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Andreas Madsen <[email protected]>
    @trevnorris
    trevnorris committed Mar 28, 2016
    Configuration menu
    Copy the full SHA
    41f333e View commit details
    Browse the repository at this point in the history

  2. src: reword command and add ternary 

    Make comment clear that Undefined() is returned for legacy
compatibility. This will change in the future as a semver-major change,
but to be able to port this to previous releases it needs to stay as is.

PR-URL: nodejs#5756
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Andreas Madsen <[email protected]>
    @trevnorris
    trevnorris committed Mar 28, 2016
    Configuration menu
    Copy the full SHA
    2dadd89 View commit details
    Browse the repository at this point in the history

  3. async_wrap: setupHooks now accepts object 

    The number of callbacks accepted to setupHooks was getting unwieldy.
Instead change the implementation to accept an object with all callbacks

PR-URL: nodejs#5756
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Andreas Madsen <[email protected]>
    @trevnorris
    trevnorris committed Mar 28, 2016
    Configuration menu
    Copy the full SHA
    f9938b6 View commit details
    Browse the repository at this point in the history

  4. async_wrap: notify post if intercepted exception 

    The second argument of the post callback is a boolean indicating whether
the callback threw and was intercepted by uncaughtException or a domain.

Currently node::MakeCallback has no way of retrieving a uid for the
object. This is coming in a future patch.

PR-URL: nodejs#5756
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Andreas Madsen <[email protected]>
    @trevnorris
    trevnorris committed Mar 28, 2016
    Configuration menu
    Copy the full SHA
    20337ad View commit details
    Browse the repository at this point in the history

  5. async_wrap: don't abort on callback exception 

    Rather than abort if the init/pre/post/final/destroy callbacks throw,
force the exception to propagate and not be made catchable. This way
the application is still not allowed to proceed but also allowed the
location of the failure to print before exiting. Though the stack itself
may not be of much use since all callbacks except init are called from
the bottom of the call stack.

    /tmp/async-test.js:14
      throw new Error('pre');
      ^
    Error: pre
        at InternalFieldObject.pre (/tmp/async-test.js:14:9)

PR-URL: nodejs#5756
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Andreas Madsen <[email protected]>
    @trevnorris
    trevnorris committed Mar 28, 2016
    Configuration menu
    Copy the full SHA
    a17200b View commit details
    Browse the repository at this point in the history