-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: minimize test-http-get-pipeline-problem #5728
Conversation
Reduce resoures required by test. Clarify comment explaining source of test and what the test is looking for. Fixes: nodejs#5725
Stress test showing flakiness on current master: https://ci.nodejs.org/job/node-stress-single-test/560/nodes=pi2-raspbian-wheezy/console |
For context: Here's a gist from @mikeal who originally reported the bug: https://gist.githubusercontent.com/mikeal/864727/raw/561f3b665df0faff6d3ee9601ef31cc3caf0376f/gistfile1.js That code fails on Node.js 0.6.0 and succeeds in 0.6.21. If we change it to this, it still failsin Node.js 0.6.0 and succeeds in 0.6.21:
The key is that |
Stress test to hopefully show that this is not flaky. Hope I didn't typo in the parameters... https://ci.nodejs.org/job/node-stress-single-test/563/nodes=pi2-raspbian-wheezy/console |
Bump. /cc @nodejs/testing |
LGTM |
LGTM |
1 similar comment
LGTM |
Reduce resoures required by test. Clarify comment explaining source of test and what the test is looking for. Fixes: #5725 PR-URL: #5728 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Landed in ccb7b45 |
Reduce resoures required by test. Clarify comment explaining source of test and what the test is looking for. Fixes: #5725 PR-URL: #5728 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Reduce resoures required by test. Clarify comment explaining source of test and what the test is looking for. Fixes: #5725 PR-URL: #5728 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Reduce resoures required by test. Clarify comment explaining source of test and what the test is looking for. Fixes: #5725 PR-URL: #5728 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Pull Request check-list
Please make sure to review and check all of these items:
make -j8 test
(UNIX) orvcbuild test nosign
(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test, http
Description of change
Reduce resoures required by test. Fixes test flakiness on Raspberry Pi in CI.
Clarify comment explaining source of test and what the test is looking
for.
Fixes: #5725