Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add note that process.send and child.send use JSON.stringify() #5723

Closed
wants to merge 1 commit into from

Conversation

mithun-daa
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

Please provide affected core subsystem(s) (like buffer, cluster, crypto, etc)

docs

Description of change

Please provide a description of the change here.

Explicitly call out that the send method on both process and child uses JSON.stringify to serialize the message
Fixes #5453

Explicitly call out that the send method on both process and child uses JSON.stringify to serialize the message
Fixes nodejs#5453
@Fishrock123 Fishrock123 added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Mar 15, 2016
@jasnell
Copy link
Member

jasnell commented Mar 15, 2016

LGTM

@whitlockjc
Copy link
Contributor

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Mar 15, 2016

LGTM

jasnell pushed a commit that referenced this pull request Mar 15, 2016
process.send and child.send use JSON.stringify to serialize
the message.

Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 15, 2016

Landed in 99a5d07

@mithun-daa ... thank you for the PR! I did update the commit message a bit to conform to our commit guidelines.

@jasnell jasnell closed this Mar 15, 2016
evanlucas pushed a commit that referenced this pull request Mar 15, 2016
process.send and child.send use JSON.stringify to serialize
the message.

Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas evanlucas mentioned this pull request Mar 15, 2016
rvagg pushed a commit that referenced this pull request Mar 16, 2016
process.send and child.send use JSON.stringify to serialize
the message.

Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
process.send and child.send use JSON.stringify to serialize
the message.

Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed doc Issues and PRs related to the documentations. labels Mar 17, 2016
@MylesBorins MylesBorins added doc Issues and PRs related to the documentations. and removed lts-watch-v4.x labels Mar 21, 2016
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
process.send and child.send use JSON.stringify to serialize
the message.

Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
process.send and child.send use JSON.stringify to serialize
the message.

Fixes: #5453
PR-URL: #5723
Reviewed-By: Jeremy Whitlock <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Child Process send incorrectly serializes values
6 participants