sqlite: allow returning ArrayBufferViews from user-defined functions
#56790
+15
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56790 +/- ##
=======================================
Coverage 89.21% 89.21%
=======================================
Files 663 663
Lines 192012 192012
Branches 36929 36931 +2
=======================================
+ Hits 171296 171300 +4
- Misses 13577 13580 +3
+ Partials 7139 7132 -7
|
targos
added
the
semver-minor
targos
approved these changes
Jan 29, 2025
cjihrig
approved these changes
Jan 29, 2025
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Jan 29, 2025
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
commit-queue
cjihrig
added
the
author ready
|
It looks like this should be able to land but the commit queue is not picking it up - possibly because GitHub thinks there are still two pending checks? |
Renegade334
force-pushed
the
sqlite-function-arraybufferview
branch
from
9fb613e to
29ff781
Compare
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56790 ✔ Done loading data for nodejs/node/pull/56790 ----------------------------------- PR info ------------------------------------ Title sqlite: allow returning `ArrayBufferView`s from user-defined functions (#56790) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch Renegade334:sqlite-function-arraybufferview -> nodejs:main Labels c++, semver-minor, author ready, needs-ci, sqlite Commits 1 - sqlite: allow returning `ArrayBufferView`s from user-defined functions Committers 1 - Renegade334 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56790 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56790 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - sqlite: allow returning `ArrayBufferView`s from user-defined functions ℹ This PR was created on Mon, 27 Jan 2025 15:30:10 GMT ✔ Approvals: 3 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/56790#pullrequestreview-2580127244 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/56790#pullrequestreview-2581083910 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56790#pullrequestreview-2581360993 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-01-29T20:29:00Z: https://ci.nodejs.org/job/node-test-pull-request/64832/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - sqlite: allow returning `ArrayBufferView`s from user-defined functions - Querying data for job/node-test-pull-request/64832/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13065470909 |
|
Oops. Can this be re-added to commit-queue? |
|
It needs to go through a full CI again since a commit was pushed. I'll kick one off. |
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
removed
the
commit-queue-failed
cjihrig
added
commit-queue
cjihrig
approved these changes
Feb 1, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2bd5694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#56385 widened the valid "blob-equivalent" type from
Uint8ArraytoArrayBufferViewfor bound parameters. This isn't currently reflected in the valid return types for user-defined functions, and it seems sensible to keep things consistent.