test: make test-crypto-hash compatible with OpenSSL > 3.4.0 #56160
+19
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
Dec 6, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56160 +/- ##
==========================================
+ Coverage 88.53% 88.54% +0.01%
==========================================
Files 657 657
Lines 190285 190285
Branches 36535 36534 -1
==========================================
+ Hits 168470 168490 +20
+ Misses 14991 14983 -8
+ Partials 6824 6812 -12 |
richardlau
reviewed
Dec 6, 2024
test/common/index.js
Outdated
Comment on lines
1062
to
1064
| get hasOpenSSL34() { | ||
| return hasOpenSSL(3, 4); | ||
| }, |
There was a problem hiding this comment.
When I added hasOpenSSL() in #53456, the idea was to stop adding new functions for every OpenSSL version to common, and instead directly call, e.g.hasOpenSSL(3, 4) in the test.
|
Can you please rebase to fix the conflict and address Richard's review? Let me know if you'd prefer me to do it instead |
aduh95
force-pushed
the
openssl-3.4.0
branch
from
93eabf6 to
4f8bc73
Compare
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Dec 25, 2024
jasnell
approved these changes
Dec 28, 2024
OpenSSL 3.4 has a breaking change where the outputLength is now mandatory for shake* hash algorithms. openssl/openssl@b911fef
The shake128/shake256 hashing algorithms broke due to an OpenSSL 3.4 incompatible change and now throws an Error.
Now that the holidays are over, done :) |
aduh95
reviewed
Jan 2, 2025
Comment on lines
34
to
+37
| for (const outputEncoding of ['buffer', 'hex', 'base64', undefined]) { | ||
| // Skip failing tests on OpenSSL 3.4.0 | ||
| if (method.startsWith("shake")) | ||
| continue; |
There was a problem hiding this comment.
Suggested change
| for (const outputEncoding of ['buffer', 'hex', 'base64', undefined]) { | |
| // Skip failing tests on OpenSSL 3.4.0 | |
| if (method.startsWith("shake")) | |
| continue; | |
| // Skip failing tests on OpenSSL 3.4.0 | |
| if (method.startsWith("shake") && common.hasOpenSSL(3, 4)) | |
| continue; | |
| for (const outputEncoding of ['buffer', 'hex', 'base64', undefined]) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL 3.4 has a breaking change where the outputLength is now mandatory for shake* hash algorithms.
openssl/openssl@b911fef
This only fixes one of the tree issues with OpenSSL 3.4. and it doesn't fix
crypto.createHash()which likely should be adjusted to be compatible with the new OpenSSL behaviour but I am unsure how that is done. I assume it should raise an InvalidArgumentError now.Refs: #56159