-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: refactor code to improve readability #55995
lib: refactor code to improve readability #55995
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55995 +/- ##
==========================================
- Coverage 88.00% 88.00% -0.01%
==========================================
Files 653 653
Lines 188093 188096 +3
Branches 35942 35943 +1
==========================================
+ Hits 165537 165538 +1
- Misses 15734 15737 +3
+ Partials 6822 6821 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about readability but one conditional check looks better than eight.
Landed in 24a8662 |
PR-URL: #55995 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: nodejs#55995 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: nodejs#55995 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: nodejs#55995 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: nodejs#55995 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
PR-URL: nodejs#55995 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
Backporting to v22.x is blocked by #55404 not being backported yet. If you open a backport PR, please include both commits |
This PR addresses this suggestion:
#55404 (comment)
@jasnell