Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,http: fix uncaughtException miss in http #5591

Merged
merged 1 commit into from
Mar 8, 2016
Merged

src,http: fix uncaughtException miss in http #5591

merged 1 commit into from
Mar 8, 2016

Commits on Mar 8, 2016

  1. src,http: fix uncaughtException miss in http 

    In AsyncWrap::MakeCallback always return empty handle if there is an
error. In the future this should change to return a v8::MaybeLocal, but
that major change will have to wait for v6.x, and these changes are
meant to be backported to v4.x.

The HTTParser call to AsyncWrap::MakeCallback failed because it expected
a thrown call to return an empty handle.

In node::MakeCallback return an empty handle if the call is
in_makecallback(), otherwise return v8::Undefined() as usual to preserve
backwards compatibility.

Fixes: nodejs#5555
PR-URL: nodejs#5591
Reviewed-By: Julien Gilli <[email protected]>
    @trevnorris
    trevnorris committed Mar 8, 2016
    Configuration menu
    Copy the full SHA
    3521b05 View commit details
    Browse the repository at this point in the history