-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
zlib: deprecate classes usage without new
#55718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
f77caf7 to
dbfed33
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55718 +/- ##
==========================================
- Coverage 87.97% 87.96% -0.01%
==========================================
Files 656 656
Lines 188391 188403 +12
Branches 35976 35975 -1
==========================================
- Hits 165732 165728 -4
- Misses 15835 15847 +12
- Partials 6824 6828 +4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually add a test, to check warning is emitted correctly
dbfed33 to
245e4f3
Compare
245e4f3 to
d93282c
Compare
d93282c to
bc8cce0
Compare
|
cc @nodejs/tsc this requires an additional TSC approval to land. |
|
Landed in 4ee87b8 |
Since we documentation-only deprecated the usage without
newqualifier, we can make it runtime deprecated.