Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented Nov 4, 2024

Since we documentation-only deprecated the usage without new qualifier, we can make it runtime deprecated.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Nov 4, 2024
@avivkeller avivkeller added semver-major PRs that contain breaking changes and should be released in the next major version. notable-change PRs with changes that should be highlighted in changelogs. labels Nov 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @redyetidev.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@avivkeller avivkeller added the deprecations Issues and PRs related to deprecations. label Nov 4, 2024
@anonrig anonrig force-pushed the yagiz/deprecate-zlib branch from f77caf7 to dbfed33 Compare November 4, 2024 16:27
@codecov
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (aa7c8cc) to head (bc8cce0).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55718      +/-   ##
==========================================
- Coverage   87.97%   87.96%   -0.01%     
==========================================
  Files         656      656              
  Lines      188391   188403      +12     
  Branches    35976    35975       -1     
==========================================
- Hits       165732   165728       -4     
- Misses      15835    15847      +12     
- Partials     6824     6828       +4     
Files with missing lines Coverage Δ
lib/zlib.js 97.51% <100.00%> (+0.03%) ⬆️

... and 25 files with indirect coverage changes

Copy link
Member

@marco-ippolito marco-ippolito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually add a test, to check warning is emitted correctly

@anonrig anonrig force-pushed the yagiz/deprecate-zlib branch from dbfed33 to 245e4f3 Compare November 8, 2024 16:41
@anonrig anonrig force-pushed the yagiz/deprecate-zlib branch from 245e4f3 to d93282c Compare November 28, 2024 17:48
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@anonrig
Copy link
Member Author

anonrig commented Nov 29, 2024

cc @nodejs/tsc this requires an additional TSC approval to land.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4ee87b8 into nodejs:main Nov 29, 2024
55 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4ee87b8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecations Issues and PRs related to deprecations. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-major PRs that contain breaking changes and should be released in the next major version. zlib Issues and PRs related to the zlib subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants