Skip to content

src: fix argv memory leaking in FixupArgsForSEA #55579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −6
Open

src: fix argv memory leaking in FixupArgsForSEA #55579

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21951c6
src: fix argv memory leaking in FixupArgsForSEA
CGQAQ Oct 29, 2024
aabe627
src: only delete[] on windows
CGQAQ Oct 29, 2024
d3552b9
src: apply joyee's suggestion
CGQAQ Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/node_sea.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,9 @@ std::tuple<int, char**> FixupArgsForSEA(int argc, char** argv) {
new_argv.emplace_back(argv[0]);
new_argv.insert(new_argv.end(), argv, argv + argc);
new_argv.emplace_back(nullptr);
#ifdef _WIN32
delete[] argv;
#endif
argc = new_argv.size() - 1;
argv = new_argv.data();
}
Expand Down
Loading