Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.x] Revert "build: do not build with code cache for core coverage collection" #55522

Closed
wants to merge 2 commits into from

Conversation

richardlau
Copy link
Member

This reverts commit 948bba3.

Refs: #55510 (comment)


Opening this PR to see if reverting 948bba3 fixes the coverage workflows on v22.x-staging.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Oct 24, 2024
@richardlau
Copy link
Member Author

Opening this PR to see if reverting 948bba3 fixes the coverage workflows on v22.x-staging.

Ah crap. I don't think the file changed by that commit will cause the workflow to trigger because of paths

paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- test/**
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-linux.yml
- codecov.yml
- .nycrc

@aduh95 aduh95 changed the title Revert "build: do not build with code cache for core coverage collection" [v22.x] Revert "build: do not build with code cache for core coverage collection" Oct 24, 2024
@richardlau
Copy link
Member Author

richardlau commented Oct 24, 2024

https://github.com/nodejs/node/actions/runs/11505175998/job/32026308742?pr=55522
Coverage build still failed to meet threshold so the cause of the threshold regression is presumably an earlier change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants