src: switch from Get/SetPrototype to Get/SetPrototypeV2
#55453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
avivkeller
force-pushed
the
v8-GetPrototypeV2-dep
branch
from
3c386ed to
d624c19
Compare
avivkeller
changed the title
GetPrototype to GetPrototypeV2Get/SetPrototype to Get/SetPrototypeV2
avivkeller
added
lib / src
avivkeller
added
author ready
github-actions
bot
removed
the
request-ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55453 +/- ##
=======================================
Coverage 88.40% 88.41%
=======================================
Files 653 653
Lines 187600 187507 -93
Branches 36117 36104 -13
=======================================
- Hits 165854 165784 -70
+ Misses 14974 14959 -15
+ Partials 6772 6764 -8
|
anonrig
approved these changes
Oct 19, 2024
MoLow
approved these changes
Oct 20, 2024
jasnell
approved these changes
Oct 20, 2024
NickNaso
approved these changes
Oct 21, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e4ca097 |
aduh95
pushed a commit
that referenced
this pull request
Oct 23, 2024
PR-URL: #55453 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#55453 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55453 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Nov 27, 2024
PR-URL: #55453 Reviewed-By: Vladimir Morozov <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
This commit does not land cleanly on |
ruyadorno
added
the
backport-requested-v22.x
samuelmaddock
added a commit
to electron/electron
that referenced
this pull request
Oct 6, 2025
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Oct 7, 2025
samuelmaddock
added a commit
to electron/electron
that referenced
this pull request
Oct 8, 2025
samuelmaddock
added a commit
to electron/electron
that referenced
this pull request
Oct 8, 2025
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Oct 9, 2025
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Oct 10, 2025
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Oct 10, 2025
samuelmaddock
added a commit
to electron/electron
that referenced
this pull request
Oct 13, 2025
* chore: bump chromium in DEPS to 142.0.7429.0 * chore: bump chromium in DEPS to 142.0.7430.0 * 6954508: Reland Migrate WrappableWithNamedPropertyInterceptor to gin::Wrappable | https://chromium-review.googlesource.com/c/chromium/src/+/6954508 * https://chromium-review.googlesource.com/c/chromium/src/+/6955633 * 5584820: Fix font face resolution when renderer is blocked | https://chromium-review.googlesource.com/c/chromium/src/+/5584820 * chore: export patches * chore: remove patch that keeley says is ok to remove in comments * chore: bump chromium in DEPS to 142.0.7432.0 * chore: export patches * chore: bump chromium in DEPS to 142.0.7434.0 * 6973697: Use type tags for data stored in V8 internal fields | https://chromium-review.googlesource.com/c/chromium/src/+/6973697 * 6976272: Revert Reland mac: click through content area in main window | https://chromium-review.googlesource.com/c/chromium/src/+/6976272 * chore: export patches * 6938086: Rename native_widget_types.h -> native_ui_types.h | https://chromium-review.googlesource.com/c/chromium/src/+/6938086 * 6951252: Correct PersistentCache backed code cache context grouping * chore: bump chromium in DEPS to 142.0.7436.0 * 6981628: Reland Use unordered_map in AcceleratorMap | https://chromium-review.googlesource.com/c/chromium/src/+/6981628 * chore: export patches * chore: resolve patch conflict with main * chore: merge conflict with main * chore: bump chromium in DEPS to 142.0.7438.0 * chore: bump chromium in DEPS to 142.0.7440.0 * chore: bump chromium in DEPS to 142.0.7442.0 * chore: bump chromium in DEPS to 142.0.7444.0 * chore: bump chromium in DEPS to 143.0.7445.0 * chore: bump chromium in DEPS to 143.0.7447.0 * chore: bump chromium in DEPS to 143.0.7449.0 * chore: bump chromium in DEPS to 143.0.7451.0 * 7001364: Migrate GURL accessors to Get* variants in //content | https://chromium-review.googlesource.com/c/chromium/src/+/7001364 * 6986521: Implicit second value 'any' instead of 'span-all' for fallback query | https://chromium-review.googlesource.com/c/chromium/src/+/6986521 * chore: update chromium patches * chore: update chromium patches * chore: update patches * fix: parse macOS SDK version across line break https://chromium-review.googlesource.com/c/chromium/src/+/6980166 * fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 nodejs/node#55453 * fix: regenerate filenames.libcxx.gni https://chromium-review.googlesource.com/c/chromium/src/+/6980307 * fix: replace additional usages of SetPrototype https://chromium-review.googlesource.com/c/v8/v8/+/6983465 * build: use macos 15 minimum https://chromium-review.googlesource.com/c/chromium/src/+/6980166 * ci: ignore missing dir for strip_universal_deep * fix: js2c compilation failure https://chromium-review.googlesource.com/c/chromium/src/+/6950738 See patch description explaining MacOS 26 SDK headers incompatibility. * fixup! chore: export patches * feat: add new memory-eviction exit reason https://chromium-review.googlesource.com/c/chromium/src/+/6991933 * fix: set JSON reader parsing options https://chromium-review.googlesource.com/c/chromium/src/+/6992114 * fix: provide DeviceEmulationCacheBehavior param https://chromium-review.googlesource.com/c/chromium/src/+/6965238 * fix: views::NonClientFrameView -> views::FrameView https://chromium-review.googlesource.com/c/chromium/src/+/7005027 https://chromium-review.googlesource.com/c/chromium/src/+/6966937 * fix: check new forced colors enum value https://chromium-review.googlesource.com/c/chromium/src/+/6944403 * fix: migrate NetworkConditions -> MatchedNetworkConditions https://chromium-review.googlesource.com/c/chromium/src/+/6827307 * fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010 * fix: disable C++ modules in electron_lib builds https://chromium-review.googlesource.com/c/chromium/src/+/6950738 * fix: partially revert is_headless_mode removal https://chromium-review.googlesource.com/c/chromium/src/+/6955633 This patch should likely be reworked. For now, this partially reverts the removal of a required class property to restore behavior. * Revert "build: use macos 15 minimum" This reverts commit 2fc12d6. Initially this change was made to test if it fixes libcxx compilation issues. As that's now resolved by disabling libcxx modules, this can be reverted. * fix: disable C++ modules in libnode builds * fixup! fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 nodejs/node#55453 * fixup! fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 nodejs/node#55453 * build: switch to macos-15 runner build/mac/find_sdk.py now requires macOS 15 SDK as a minimum version. The macos 15 runners default to an Xcode using the 15 SDK and removes older versions. * fixup! fix: check new forced colors enum value https://chromium-review.googlesource.com/c/chromium/src/+/6944403 * fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010 * fix: use std::u16string for Extension::Create() error parameter https://chromium-review.googlesource.com/c/chromium/src/+/6975452 * fix: add missing image_skia include https://chromium-review.googlesource.com/c/chromium/src/+/6986762 * fixup! fix: add missing image_skia include https://chromium-review.googlesource.com/c/chromium/src/+/6986762 * fix: remove outdated V8 flag https://chromium-review.googlesource.com/c/v8/v8/+/6948286 * fix: disable protocol handler DCHECK https://chromium-review.googlesource.com/c/chromium/src/+/6727594 Ignore the extension custom protocol handler registry DCHECK until we invest in supporting it. Replacing this DCHECK seems harmless and will unblock the roll. * fix: replace deprecated usage of SetPrototype https://chromium-review.googlesource.com/c/v8/v8/+/6983465 * fixup! fix: migrate NetworkConditions -> MatchedNetworkConditions https://chromium-review.googlesource.com/c/chromium/src/+/6827307 * fixup! fix: migrate GURL string methods to Get*() https://chromium-review.googlesource.com/c/chromium/src/+/7007010 * chore: remove patch already included in roll * chore: remove extraneous formatting added to patch * chore: remove fix_harden_blink_scriptstate_maybefrom.patch https://chromium-review.googlesource.com/c/chromium/src/+/6973697 No longer needed since the above CL landed. * 6973697: Use type tags for data stored in V8 internal fields https://chromium-review.googlesource.com/c/chromium/src/+/6973697 * chore: update patches * fixup! chore: export patches * chore: restore electron embedder data tag patch --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Alice Zhao <[email protected]> Co-authored-by: Keeley Hammond <[email protected]> Co-authored-by: Samuel Maddock <[email protected]> Co-authored-by: John Kleinschmidt <[email protected]>
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Oct 13, 2025
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Oct 13, 2025
jkleinsc
added a commit
to electron/electron
that referenced
this pull request
Oct 14, 2025
* chore: bump chromium in DEPS to 142.0.7432.2 * chore: bump chromium in DEPS to 142.0.7434.1 * chore: bump chromium in DEPS to 142.0.7436.1 * chore: bump chromium in DEPS to 142.0.7438.1 * chore: bump chromium in DEPS to 142.0.7440.1 * chore: bump chromium in DEPS to 142.0.7442.1 * chore: bump chromium in DEPS to 142.0.7444.1 * chore: bump chromium in DEPS to 142.0.7444.6 * chore: bump chromium in DEPS to 142.0.7444.3 * 6973697: Use type tags for data stored in V8 internal fields https://chromium-review.googlesource.com/c/chromium/src/+/6973697 * chore: update patches * chore: update filenames.libcxx.gni * fix: parse macOS SDK version across line break https://chromium-review.googlesource.com/c/chromium/src/+/6980166 (cherry picked from commit 2bcbb33) * fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 nodejs/node#55453 (cherry picked from commit c31b9ed) * fix: replace additional usages of SetPrototype https://chromium-review.googlesource.com/c/v8/v8/+/6983465 (cherry picked from commit bf151e9) * fixup! fix: replace additional usages of SetPrototype https://chromium-review.googlesource.com/c/v8/v8/+/6983465 (cherry picked from commit f443475) * build: use macos 15 minimum https://chromium-review.googlesource.com/c/chromium/src/+/6980166 (cherry picked from commit 4d2b5d7) * fixup! build: use macos 15 minimum https://chromium-review.googlesource.com/c/chromium/src/+/6980166 (cherry picked from commit 94bb41a) * ci: ignore missing dir for strip_universal_deep (cherry picked from commit 634963f) * chore: update patches * chore: update patches * chore: bump chromium in DEPS to 142.0.7444.23 * fix: disable C++ modules in electron_lib builds https://chromium-review.googlesource.com/c/chromium/src/+/6950738 (cherry picked from commit 6207c79) * Revert "build: use macos 15 minimum" This reverts commit 2fc12d6. Initially this change was made to test if it fixes libcxx compilation issues. As that's now resolved by disabling libcxx modules, this can be reverted. (cherry picked from commit ad52007) * fix: js2c compilation failure https://chromium-review.googlesource.com/c/chromium/src/+/6950738 See patch description explaining MacOS 26 SDK headers incompatibility. (cherry picked from commit 39e2470) * fix: disable C++ modules in libnode builds (cherry picked from commit fd0a7b6) * fixup! fix: replace v8::Object::SetPrototype() usage https://chromium-review.googlesource.com/c/v8/v8/+/6983465 nodejs/node#55453 (cherry picked from commit 2f52159) * build: switch to macos-15 runner build/mac/find_sdk.py now requires macOS 15 SDK as a minimum version. The macos 15 runners default to an Xcode using the 15 SDK and removes older versions. (cherry picked from commit e368703) * chore: update patches * fix: partially revert is_headless_mode removal https://chromium-review.googlesource.com/c/chromium/src/+/6955633 This patch should likely be reworked. For now, this partially reverts the removal of a required class property to restore behavior. (cherry picked from commit aff3bf9) * 6938086: Rename native_widget_types.h -> native_ui_types.h | https://chromium-review.googlesource.com/c/chromium/src/+/6938086 (cherry picked from commit c95ac7b) * 6973697: Use type tags for data stored in V8 internal fields https://chromium-review.googlesource.com/c/chromium/src/+/6973697 * fixup! fix: check new forced colors enum value https://chromium-review.googlesource.com/c/chromium/src/+/6944403 (cherry picked from commit 0829c74) * fix: check new forced colors enum value https://chromium-review.googlesource.com/c/chromium/src/+/6944403 (cherry picked from commit d585879) * feat: add new memory-eviction exit reason https://chromium-review.googlesource.com/c/chromium/src/+/6991933 (cherry picked from commit 6e63197) * fix: views::NonClientFrameView -> views::FrameView https://chromium-review.googlesource.com/c/chromium/src/+/7005027 https://chromium-review.googlesource.com/c/chromium/src/+/6966937 (cherry picked from commit 1e86b6d) * fix: migrate NetworkConditions -> MatchedNetworkConditions https://chromium-review.googlesource.com/c/chromium/src/+/6827307 (cherry picked from commit 97100ac) * fix: provide DeviceEmulationCacheBehavior param https://chromium-review.googlesource.com/c/chromium/src/+/6965238 (cherry picked from commit f9a08c5) * fix: add missing image_skia include https://chromium-review.googlesource.com/c/chromium/src/+/6986762 (cherry picked from commit dd5eaf0) * fixup! fix: add missing image_skia include https://chromium-review.googlesource.com/c/chromium/src/+/6986762 (cherry picked from commit 249c4d4) * 6948286: [wasm-imported-strings] Drop feature flag https://chromium-review.googlesource.com/c/v8/v8/+/6948286 * fix: disable protocol handler DCHECK https://chromium-review.googlesource.com/c/chromium/src/+/6727594 Ignore the extension custom protocol handler registry DCHECK until we invest in supporting it. Replacing this DCHECK seems harmless and will unblock the roll. (cherry picked from commit 019d3f0) * 6986762: Remove some includes of //ui/gfx/image/image_skia.h https: //chromium-review.googlesource.com/c/chromium/src/+/6986762 * fixup! fix: migrate NetworkConditions -> MatchedNetworkConditions https://chromium-review.googlesource.com/c/chromium/src/+/6827307 (cherry picked from commit a8f67f1) * fixup: 6986762: Remove some includes of //ui/gfx/image/image_skia.h s * fix: replace deprecated usage of SetPrototype https://chromium-review.googlesource.com/c/v8/v8/+/6983465 (cherry picked from commit 5435d87) * chore: restore electron embedder data tag patch Co-Authored-By: Sam Maddock <[email protected]> * chore: update patches --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <[email protected]> Co-authored-by: Samuel Maddock <[email protected]> Co-authored-by: Alice Zhao <[email protected]> Co-authored-by: Sam Maddock <[email protected]>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #55452
GetPrototypehas been deprecated in favor ofGetPrototypeV2. See https://issues.chromium.org/issues/333672197