Skip to content

Conversation

geeksilva97
Copy link
Contributor

PR: #55354

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Oct 15, 2024
@avivkeller
Copy link
Member

Why? The original PR lands cleanly:

$ git cherry-pick 7a7c2b3d0953fa5a8bb69a5d865fce98e0c60669
Auto-merging lib/internal/abort_controller.js
[detached HEAD 7a3ea74466] lib: remove settled dependant signals when they are GCed
 Author: Edigleysson Silva (Edy) <[email protected]>
 Date: Mon Oct 14 17:33:41 2024 -0300
 2 files changed, 145 insertions(+), 9 deletions(-)
 create mode 100644 test/parallel/test-abortsignal-drop-settled-signals.mjs

@geeksilva97
Copy link
Contributor Author

Why? The original PR lands cleanly:

$ git cherry-pick 7a7c2b3d0953fa5a8bb69a5d865fce98e0c60669
Auto-merging lib/internal/abort_controller.js
[detached HEAD 7a3ea74466] lib: remove settled dependant signals when they are GCed
 Author: Edigleysson Silva (Edy) <[email protected]>
 Date: Mon Oct 14 17:33:41 2024 -0300
 2 files changed, 145 insertions(+), 9 deletions(-)
 create mode 100644 test/parallel/test-abortsignal-drop-settled-signals.mjs

Hm, so it goes to lower versions? I didn't know that. Thanks for letting me know @redyetidev ! will close both.

@avivkeller
Copy link
Member

For future reference, a backport is only needed if, when trying to prepare a release, a releaser can't cleanly apply a change. Most changes can be cleanly applied.

@geeksilva97 geeksilva97 deleted the backport-55354-to-v20.x branch May 20, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants