Skip to content

test_runner: fix TypeError exception when --enable-source-maps is passed #55231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2024
Merged

test_runner: fix TypeError exception when --enable-source-maps is passed #55231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e2ab53
test_runner: assert entry is a valid object
geeksilva97 Oct 2, 2024
025f1a9
test: test case when --enable-source-maps is provided
geeksilva97 Oct 2, 2024
5a98f1c
test: move --enable-source-maps test to a single file
geeksilva97 Oct 2, 2024
b208245
chore: rebase cleanup
geeksilva97 Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/internal/test_runner/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ class Test extends AsyncResource {
const map = lazyFindSourceMap(this.loc.file);
const entry = map?.findEntry(this.loc.line - 1, this.loc.column - 1);

if (entry !== undefined) {
if (entry?.originalSource !== undefined) {
this.loc.line = entry.originalLine + 1;
this.loc.column = entry.originalColumn + 1;
this.loc.file = entry.originalSource;
Expand Down
16 changes: 16 additions & 0 deletions test/parallel/test-runner-enable-source-maps-issue.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';
require('../common');
const assert = require('node:assert');
const { spawnSync } = require('node:child_process');
const { test } = require('node:test');
const fixtures = require('../common/fixtures');

test('ensures --enable-source-maps does not throw an error', () => {
const fixture = fixtures.path('test-runner', 'coverage', 'stdin.test.js');
const args = ['--enable-source-maps', fixture];

const result = spawnSync(process.execPath, args);

assert.strictEqual(result.stderr.toString(), '');
assert.strictEqual(result.status, 0);
});
Loading