-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: enforce errors to not be documented in legacy section #55218
Open
RedYetiDev
wants to merge
3
commits into
nodejs:main
Choose a base branch
from
RedYetiDev:patch-531581
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+128
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
labels
Oct 1, 2024
RedYetiDev
force-pushed
the
patch-531581
branch
from
October 1, 2024 20:43
c692109
to
3cb26b0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55218 +/- ##
==========================================
- Coverage 88.41% 88.40% -0.02%
==========================================
Files 652 652
Lines 186572 186572
Branches 36045 36041 -4
==========================================
- Hits 164957 164938 -19
- Misses 14899 14905 +6
- Partials 6716 6729 +13 |
aduh95
reviewed
Oct 2, 2024
aduh95
reviewed
Oct 2, 2024
aduh95
changed the title
doc: put errors in right location
tools: enforce errors to not be documented in legacy section
Oct 2, 2024
RedYetiDev
force-pushed
the
patch-531581
branch
from
October 2, 2024 16:21
2ac71fc
to
cebf21d
Compare
ack! That's not what I meant to do. I'll reopen in a moment. |
aduh95
reviewed
Oct 2, 2024
Can you please rebase? |
RedYetiDev
force-pushed
the
patch-531581
branch
from
October 2, 2024 20:00
fc9ce25
to
e928f45
Compare
aduh95
reviewed
Oct 2, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
RedYetiDev
added
the
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
label
Oct 2, 2024
aduh95
approved these changes
Oct 2, 2024
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Oct 2, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
doc
Issues and PRs related to the documentations.
errors
Issues and PRs related to JavaScript errors originated in Node.js core.
tools
Issues and PRs related to the tools directory.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the lint rule to enforce that errors are in the right category. That is, errors that exist are not placed under the
deprecated
cateogory.