Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: coerce extrema to int in blob.slice #55141

Merged
merged 2 commits into from
Sep 29, 2024
Merged

buffer: coerce extrema to int in blob.slice #55141

merged 2 commits into from
Sep 29, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 27, 2024

Fixes: #55139

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 27, 2024
@RedYetiDev RedYetiDev added the buffer Issues and PRs related to the buffer subsystem. label Sep 27, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (772b35b) to head (567c892).
Report is 29 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55141      +/-   ##
==========================================
- Coverage   88.25%   88.24%   -0.02%     
==========================================
  Files         651      651              
  Lines      183916   183905      -11     
  Branches    35866    35861       -5     
==========================================
- Hits       162315   162280      -35     
- Misses      14900    14914      +14     
- Partials     6701     6711      +10
Files with missing lines Coverage Δ
lib/internal/blob.js 99.80% <100.00%> (+<0.01%) ⬆️

... and 35 files with indirect coverage changes

@aduh95
Copy link
Contributor Author

aduh95 commented Sep 27, 2024

It looks like this PR is reverting bf8afe7

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62805/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/62809/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 27, 2024
@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Sep 28, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4062b3f into nodejs:main Sep 29, 2024
65 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4062b3f

@aduh95 aduh95 deleted the blob-slice-int branch September 29, 2024 12:30
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95 @targos
buffer: coerce extrema to int in blob.slice
e83ad0b 
PR-URL: #55141
Fixes: #55139
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2024
@aduh95 @targos
buffer: coerce extrema to int in blob.slice
b1ebb0d 
PR-URL: #55141
Fixes: #55139
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 9, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@aduh95 @louwers
buffer: coerce extrema to int in blob.slice
3d72697 
PR-URL: nodejs#55141
Fixes: nodejs#55139
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion failed: args[1]->IsUint32() when slicing Blob with non-integer parameters
6 participants
@aduh95 @nodejs-github-bot @jasnell @benjamingr @lpinca @RedYetiDev