test: allow options for v8 testing #5502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow extra options when testing v8 in Node tree
|
LGTM although I don't really see why you'd need V8_EXTRA_TEST_OPTIONS when V8_TEST_OPTIONS exists as well. |
|
I tried with just V8_TEST_OPTIONS, but it was not additive. When V8_TEST_OPTIONS was specified in the environment the --noi18n was not added. |
|
Issues in CI look like infra issue (timeout on ARM), win2015 compile job failed even thought it looks like it was successful: |
mhdawson
added a commit
that referenced
this pull request
Mar 1, 2016
Allow extra options when testing v8 in Node tree PR-URL: #5502 Reviewed-By: Ben Noordhuis <[email protected]>
|
Landed as 32a2a60 |
Fishrock123
pushed a commit
that referenced
this pull request
Mar 2, 2016
Allow extra options when testing v8 in Node tree PR-URL: #5502 Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make test passes
Affected core subsystem(s)
v8
Description of change
Allow extra options when testing v8 in Node tree (see nodejs/build#199 for more details). The extra options can be set by setting them in 8_EXTRA_TEST_OPTIONS.
I've found this is needed while investigating #5263 will be generally useful. In particular for the CI job I want to use progress=dots instead of the more verbose default output