-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: runtime deprecate toUSVString() #55018
Conversation
c69bb5e
to
962ea51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually add a test to check warning is emitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide some context on why we are deprecating it? It's useful for users that will read the v23 changelog.
Don't we also need to update the docs? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55018 +/- ##
=======================================
Coverage 88.04% 88.04%
=======================================
Files 652 652
Lines 183764 183767 +3
Branches 35862 35862
=======================================
+ Hits 161787 161798 +11
+ Misses 15233 15223 -10
- Partials 6744 6746 +2
|
I think this will result in a lot of warning on unmaintained modules. What cost is there in keeping this? |
Cost of keeping |
Let's runtime deprecate
toUSVString()
cc @nodejs/tsc