-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: expose getPackageScopeConfig
& add findNearestPackageJSON
#54992
base: main
Are you sure you want to change the base?
module: expose getPackageScopeConfig
& add findNearestPackageJSON
#54992
Conversation
Review requested:
|
@@ -64,6 +71,7 @@ function deserializePackageJSON(path, contents) { | |||
ObjectDefineProperty(this, 'exports', { __proto__: null, value }); | |||
return this.exports; | |||
}, | |||
...(everything && contents[6]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be explicit? Depending on the package.json this can overwrite existing values in this object
void BindingData::GetNearestParentPackageJSON( | ||
const v8::FunctionCallbackInfo<v8::Value>& args | ||
) { | ||
std::string path_value_str = FindNearestParentPackageJSON(args); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to append the type to the variable name
std::string path_value_str = FindNearestParentPackageJSON(args); | |
auto path = FindNearestParentPackageJSON(args); |
args.GetReturnValue().Set(path_value_str); | ||
} | ||
|
||
void BindingData::GetNearestParentPackageJSON( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to also update typings folder.
This draft is not ready for review. Opening it in its current state for visibility.