lib, tools: remove duplicate requires #54987
Open
+42
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
RedYetiDev
commented
Sep 17, 2024
| @@ -48,7 +48,6 @@ function resolveMainPath(main) { | |||
| } catch (err) { | |||
| if (defaultType === 'module' && err?.code === 'ENOENT') { | |||
| const { decorateErrorWithCommonJSHints } = require('internal/modules/esm/resolve'); | |||
| const { getCWDURL } = require('internal/util'); | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54987 +/- ##
==========================================
- Coverage 88.06% 88.06% -0.01%
==========================================
Files 652 652
Lines 183545 183523 -22
Branches 35854 35854
==========================================
- Hits 161648 161617 -31
- Misses 15146 15149 +3
- Partials 6751 6757 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #54892
Updates the eslint rule to check if a require in a function is already defined at the top-level.