-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix invalid test #54935
Merged
Merged
test: fix invalid test #54935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
esm
Issues and PRs related to the ECMAScript Modules implementation.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
labels
Sep 14, 2024
avivkeller
added
loaders
Issues and PRs related to ES module loaders
esm
Issues and PRs related to the ECMAScript Modules implementation.
needs-ci
PRs that need a full CI run.
and removed
esm
Issues and PRs related to the ECMAScript Modules implementation.
needs-ci
PRs that need a full CI run.
labels
Sep 14, 2024
avivkeller
force-pushed
the
patch-504488
branch
from
September 14, 2024 00:50
c262d44
to
cc05123
Compare
avivkeller
force-pushed
the
patch-504488
branch
from
September 14, 2024 00:52
cc05123
to
b5aa5a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54935 +/- ##
=======================================
Coverage 88.06% 88.07%
=======================================
Files 651 651
Lines 183451 183451
Branches 35821 35827 +6
=======================================
+ Hits 161564 161574 +10
+ Misses 15133 15130 -3
+ Partials 6754 6747 -7 |
benjamingr
approved these changes
Sep 14, 2024
lpinca
approved these changes
Sep 17, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Sep 17, 2024
avivkeller
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Sep 18, 2024
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 20, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Sep 20, 2024
Landed in 2a1607c |
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54935 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54935 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
marco-ippolito
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Nov 16, 2024
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54935 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
esm
Issues and PRs related to the ECMAScript Modules implementation.
loaders
Issues and PRs related to ES module loaders
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test setup is incorrect:
In the correct setup,
mustNotCall()
should be invoked asmustNotCall()();
. However, the test fails in this case, indicating that the import is actually successful. This PR fixes the invalid test.