module: support loading entrypoint as url #54933
Open
+140
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
RedYetiDev
added
semver-minor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54933 +/- ##
==========================================
- Coverage 88.06% 88.06% -0.01%
==========================================
Files 651 651
Lines 183451 183543 +92
Branches 35821 35863 +42
==========================================
+ Hits 161564 161642 +78
- Misses 15133 15138 +5
- Partials 6754 6763 +9
|
jasnell
reviewed
Sep 14, 2024
jasnell
approved these changes
Sep 14, 2024
RedYetiDev
force-pushed
the
entry-url
branch
from
4b36a9e
to
9d90d6c
Compare
LiviaMedeiros
approved these changes
Sep 14, 2024
There was a problem hiding this comment.
The code LGTM.
Adding more tests (and maybe examples in the docs) would be appreciated, and i think it should be more clear that --entry-url is a binary flag that doesn't require --entry-url <URL> syntax, i.e. node --any-flags file:///file.mjs --any-flags --entry-url --any-flags also works.
Also, IIRC src subsystem exists mainly for generic changes (just like lib), so just module should be sufficient.
RedYetiDev
force-pushed
the
entry-url
branch
from
9d90d6c
to
bebf291
Compare
RedYetiDev
changed the title
Co-Authored-By: Antoine du Hamel <[email protected]>
RedYetiDev
force-pushed
the
entry-url
branch
from
bebf291
to
8233681
Compare
aduh95
reviewed
Sep 19, 2024
| if (mainURL === undefined) { | ||
| mainURL = pathToFileURL(mainPath).href; | ||
| } | ||
| const mainURL = getOptionValue('--entry-url') ? new URL(mainPath, getCWDURL()).href : pathToFileURL(mainPath).href; |
There was a problem hiding this comment.
We can avoid repeating the .href here, and we should probably rename mainPath.
Suggested change
| const mainURL = getOptionValue('--entry-url') ? new URL(mainPath, getCWDURL()).href : pathToFileURL(mainPath).href; | |
| const mainURL = getOptionValue('--entry-url') ? new URL(mainPathOrURL, getCWDURL()) : pathToFileURL(mainPathOrURL); |
aduh95
reviewed
Sep 19, 2024
| } | ||
|
|
||
| assert.strictEqual(code, expected.code ?? 0); | ||
| assert.strictEqual(signal, expected.signal ?? signal); |
There was a problem hiding this comment.
Suggested change
| assert.strictEqual(signal, expected.signal ?? signal); | |
| assert.strictEqual(signal, expected.signal ?? null); |
aduh95
reviewed
Sep 19, 2024
| {}, | ||
| { | ||
| ...experimentalFeatureWarning, | ||
| stdout: /data:text\/javascript,console\.log\(import\.meta\.url\)/, |
There was a problem hiding this comment.
Suggested change
| stdout: /data:text\/javascript,console\.log\(import\.meta\.url\)/, | |
| stdout: /^data:text\/javascript,console\.log\(import\.meta\.url\)\r?\n$/, |
aduh95
reviewed
Sep 19, 2024
| { cwd: fixtures.fileURL('./') }, | ||
| { | ||
| ...experimentalFeatureWarning, | ||
| stdout: /print-entrypoint\.mjs\?key=value#hash/, |
There was a problem hiding this comment.
Suggested change
| stdout: /print-entrypoint\.mjs\?key=value#hash/, | |
| stdout: /print-entrypoint\.mjs\?key=value#hash\r?\n$/, |
aduh95
reviewed
Sep 19, 2024
| {}, | ||
| { | ||
| ...experimentalFeatureWarning, | ||
| stdout: /A/, |
There was a problem hiding this comment.
Suggested change
| stdout: /A/, | |
| stdout: /^A\r?\n$/, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #49975
Fixes?: #46009
Fixes?: #49204
The original PR stalled, so I addressed the comments, and reimplemented it in a way that it works with the latest Node.js codebase.