Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding more tests for strip-types #54929

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

test: adding more tests for strip-types #54929

wants to merge 7 commits into from
+102 −0

Conversation

kevinuehara
Copy link

In this MR I'm adding more tests created in this PR, testing generics and Utility Types.
This PR makes part of typescript iniciative on Node.

cc: @RedYetiDev @marco-ippolito @ErickWendel

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support test Issues and PRs related to the tests. labels Sep 13, 2024
RedYetiDev
RedYetiDev reviewed Sep 13, 2024
View reviewed changes
test/es-module/test-typescript.mjs Outdated Show resolved Hide resolved
test/es-module/test-typescript.mjs Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Sep 13, 2024
@marco-ippolito
Copy link
Member

Again commits do not point to your github profile or email

@RedYetiDev
Copy link
Member

Again commits do not point to your github profile or email

The commits point to Kevin Uehara <[email protected]>, whereas your github profile's commits point to Gayathri <[email protected]>

@kevinuehara kevinuehara force-pushed the kevinuehara/adding-typescript-tests branch from 0d4dde4 to e1fbc08 Compare September 13, 2024 21:16
@kevinuehara
Copy link
Author

kevinuehara commented Sep 13, 2024 •
edited
Loading

@marco-ippolito @RedYetiDev I update the author of commits... the ifood account is my work author :)

@RedYetiDev
Copy link
Member

@marco-ippolito how does this fixture compare to the other ones? Just want to make sure they are all similar

@marco-ippolito
Copy link
Member

marco-ippolito commented Sep 19, 2024 •
edited
Loading

To be honest I dont think there is much value in testing TypeScript features such as Unions and Generics, since we rely on swc and swc tests that the output they produce is correct. Im ok with asserting that parameter properties throw in striptypes mode

@kevinuehara
Copy link
Author

@marco-ippolito @RedYetiDev Do you think we can merge this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito Awaiting requested review from marco-ippolito

@RedYetiDev RedYetiDev Awaiting requested review from RedYetiDev

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinuehara @nodejs-github-bot @marco-ippolito @RedYetiDev