Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update ada to 2.9.2 #54679

Merged
merged 2 commits into from
Oct 21, 2024
Merged

deps: update ada to 2.9.2 #54679

merged 2 commits into from
Oct 21, 2024

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Sep 1, 2024 •
edited
Loading

This is an automated update of ada to 2.9.2.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Sep 1, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 1, 2024
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 1, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot nodejs-github-bot changed the title deps: update ada to 2.9.1 deps: update ada to 2.9.2 Sep 8, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/62145/

@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 4, 2024
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/62919/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/62979/

mhdawson
mhdawson approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2024
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 11, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/54679
✔  Done loading data for nodejs/node/pull/54679
----------------------------------- PR info ------------------------------------
Title      deps: update ada to 2.9.2 (#54679)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-ada -> nodejs:main
Labels     author ready, needs-ci, dependencies
Commits    2
 - deps: update ada to 2.9.1
 - deps: update ada to 2.9.2
Committers 1
 - Node.js GitHub Bot <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54679
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54679
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 01 Sep 2024 00:34:23 GMT
   ✔  Approvals: 7
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54679#pullrequestreview-2274163350
   ✔  - Daniel Lemire (@lemire): https://github.com/nodejs/node/pull/54679#pullrequestreview-2274165171
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54679#pullrequestreview-2288482934
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54679#pullrequestreview-2288430678
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54679#pullrequestreview-2288434235
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/54679#pullrequestreview-2352738864
   ✔  - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54679#pullrequestreview-2362747112
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-10-07T19:11:39Z: https://ci.nodejs.org/job/node-test-pull-request/62979/
- Querying data for job/node-test-pull-request/62979/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 54679
From https://github.com/nodejs/node
 * branch                  refs/pull/54679/merge -> FETCH_HEAD
✔  Fetched commits as e9904fe49af2..56f85f0ca3c2
--------------------------------------------------------------------------------
[main fc1eddfb25] deps: update ada to 2.9.1
 Date: Sun Sep 1 00:34:21 2024 +0000
 2 files changed, 65 insertions(+), 28 deletions(-)
[main 6aad4c767c] deps: update ada to 2.9.2
 Date: Sun Sep 8 00:31:44 2024 +0000
 2 files changed, 10 insertions(+), 10 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

deps: update ada to 2.9.1


PR-URL: #54679

Reviewed-By: Yagiz Nizipli <[email protected]>

Reviewed-By: Daniel Lemire <[email protected]>

Reviewed-By: Marco Ippolito <[email protected]>

Reviewed-By: James M Snell <[email protected]>

Reviewed-By: Rafael Gonzaga <[email protected]>

Reviewed-By: Michael Dawson <[email protected]>

Reviewed-By: Jake Yuesong Li <[email protected]>


[detached HEAD 97ef0d9a5e] deps: update ada to 2.9.1

Date: Sun Sep 1 00:34:21 2024 +0000

2 files changed, 65 insertions(+), 28 deletions(-)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

deps: update ada to 2.9.2


PR-URL: #54679

Reviewed-By: Yagiz Nizipli <[email protected]>

Reviewed-By: Daniel Lemire <[email protected]>

Reviewed-By: Marco Ippolito <[email protected]>

Reviewed-By: James M Snell <[email protected]>

Reviewed-By: Rafael Gonzaga <[email protected]>

Reviewed-By: Michael Dawson <[email protected]>

Reviewed-By: Jake Yuesong Li <[email protected]>


[detached HEAD 053cdbd5d8] deps: update ada to 2.9.2

Date: Sun Sep 8 00:31:44 2024 +0000

2 files changed, 10 insertions(+), 10 deletions(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/11294014768

@mhdawson mhdawson added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 21, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4d51c60 into main Oct 21, 2024
73 checks passed
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 4d51c60

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-ada branch October 21, 2024 15:51
aduh95 pushed a commit that referenced this pull request Oct 23, 2024
@nodejs-github-bot @aduh95
deps: update ada to 2.9.1
c2b5ebf 
PR-URL: #54679
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
Merged
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@nodejs-github-bot @louwers
deps: update ada to 2.9.1
1bf79a2 
PR-URL: nodejs#54679
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@nodejs-github-bot @lemire @jasnell @anonrig @mhdawson @RafaelGSS @marco-ippolito @jakecastelli