-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix module compile cache description #54625
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
ShenHongFei:fix/module-compile-cache-doc
Aug 29, 2024
Merged
doc: fix module compile cache description #54625
nodejs-github-bot
merged 1 commit into
nodejs:main
from
ShenHongFei:fix/module-compile-cache-doc
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
doc
Issues and PRs related to the documentations.
module
Issues and PRs related to the module subsystem.
labels
Aug 29, 2024
@joyeecheung There is a mistake in the document. About this PR (#54501) |
joyeecheung
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching it!
joyeecheung
added
the
fast-track
PRs that do not need to wait for 48 hours to land.
label
Aug 29, 2024
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
aduh95
approved these changes
Aug 29, 2024
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 29, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 29, 2024
Landed in 99b491c |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54625 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54625 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
PR-URL: #54625 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Sep 22, 2024
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54625 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
doc
Issues and PRs related to the documentations.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
fast-track
PRs that do not need to wait for 48 hours to land.
module
Issues and PRs related to the module subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the wrong environment variables in the module compile cache documentation