Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update websocket flag description to reflect stable API status #54482

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

debbs061
Copy link
Contributor

This updates the documentation for the --no-experimental-websocket flag. The WebSocket is no longer experimental, and the description has been revised to clarify that the flag now disables the exposition of the WebSocket on the global scope.

cc. @KhafraDev

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Aug 21, 2024
@debbs061 debbs061 closed this Aug 21, 2024
@debbs061 debbs061 reopened this Aug 21, 2024
doc: update websocket flag description to reflect stable API status

doc: revert syntax detection description
@KhafraDev KhafraDev added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 21, 2024
@nodejs-github-bot
Copy link
Collaborator

@daeyeon daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6dce10f into nodejs:main Aug 24, 2024
51 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6dce10f

RafaelGSS pushed a commit that referenced this pull request Aug 25, 2024
doc: update websocket flag description to reflect stable API status

doc: revert syntax detection description
PR-URL: #54482
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 25, 2024
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
doc: update websocket flag description to reflect stable API status

doc: revert syntax detection description
PR-URL: #54482
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants