-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update websocket flag description to reflect stable API status #54482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
cli
Issues and PRs related to the Node.js command line interface.
doc
Issues and PRs related to the documentations.
labels
Aug 21, 2024
debbs061
force-pushed
the
update-websocket-doc
branch
from
August 21, 2024 13:36
bc21ed1
to
8b3aa17
Compare
doc: update websocket flag description to reflect stable API status doc: revert syntax detection description
debbs061
force-pushed
the
update-websocket-doc
branch
from
August 21, 2024 13:41
d3ddb39
to
cf90c3b
Compare
KhafraDev
approved these changes
Aug 21, 2024
KhafraDev
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 21, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 21, 2024
benjamingr
approved these changes
Aug 21, 2024
UlisesGascon
approved these changes
Aug 22, 2024
lpinca
approved these changes
Aug 22, 2024
daeyeon
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 24, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 24, 2024
Landed in 6dce10f |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 25, 2024
doc: update websocket flag description to reflect stable API status doc: revert syntax detection description PR-URL: #54482 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 30, 2024
doc: update websocket flag description to reflect stable API status doc: revert syntax detection description PR-URL: #54482 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
cli
Issues and PRs related to the Node.js command line interface.
doc
Issues and PRs related to the documentations.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documentation for the --no-experimental-websocket flag. The WebSocket is no longer experimental, and the description has been revised to clarify that the flag now disables the exposition of the WebSocket on the global scope.
cc. @KhafraDev