Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made a note about sync and major release #54370

Closed
wants to merge 1 commit into from
Closed

Conversation

isid555
Copy link

@isid555 isid555 commented Aug 14, 2024

#54361
@targos
Enhanced once again

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Aug 14, 2024
@RedYetiDev
Copy link
Member

I believe the note should go in https://github.com/nodejs/node/blob/main/doc/contributing/releases.md rather than the README.

Additionally, I believe you may have accidentally updated an unrelated file.

@RedYetiDev RedYetiDev added meta Issues and PRs related to the general management of the project. and removed v8 engine Issues and PRs related to the V8 dependency. needs-ci PRs that need a full CI run. labels Aug 14, 2024
@RedYetiDev RedYetiDev closed this Aug 14, 2024
@RedYetiDev
Copy link
Member

Closing in favor of your other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants