src: shift even moar x509 to ncrypto #54340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Aug 12, 2024
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
use-ncrypto-moar-2
branch
from
c746002
to
f2ef1b2
Compare
jasnell
force-pushed
the
use-ncrypto-moar-2
branch
from
f2ef1b2
to
74c6839
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
crypto
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
commit-queue-squash
jasnell
added a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54340 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
|
Landed in 6261187 |
|
@jasnell nitpic the commit has a typo. moar->more |
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 19, 2024
PR-URL: #54340 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 21, 2024
PR-URL: #54340 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nodejs/crypto @nodejs/cpp-reviewers