doc,tools,test: lint doc-based addon tests #5427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
doc
This was referenced Feb 25, 2016
|
LGTM Closing #5425 |
|
LGTM |
1 similar comment
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Feb 26, 2016
PR-URL: nodejs#5427 Fixes: nodejs#5424 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Myles Borins <[email protected]>
|
Landed in 3e3d941 @thealphanerd You probably want to land this on v4.x-staging sooner rather than later, yeah? |
|
@Trott I'll take a peak at this today the esline 2 stuff has not yet been landed, you might want to just cherry pick this commit on top of that PR |
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
PR-URL: #5427 Fixes: #5424 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Myles Borins <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Feb 27, 2016
PR-URL: #5427 Fixes: #5424 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2016
PR-URL: #5427 Fixes: #5424 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 1, 2016
PR-URL: #5427 Fixes: #5424 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Myles Borins <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #5427 Fixes: #5424 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify doc-based addon tests (from addon doc examples) so that they pass linting.
Fixes: #5424
This is perhaps an alternative (or follow-on) for #5425.
/cc @thealphanerd