Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: modify pathToFileURL to handle extended UNC paths #54262

Merged
merged 1 commit into from
Aug 12, 2024
Merged

url: modify pathToFileURL to handle extended UNC paths #54262

merged 1 commit into from
Aug 12, 2024

Conversation

EarlyRiser42
Copy link
Contributor

Fixes #54261

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Aug 8, 2024
@RedYetiDev RedYetiDev added url Issues and PRs related to the legacy built-in url module. windows Issues and PRs related to the Windows platform. labels Aug 8, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (2bcf999) to head (68f519f).
Report is 38 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #54262   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files         647      647           
  Lines      181754   181759    +5     
  Branches    34883    34887    +4     
=======================================
+ Hits       158316   158323    +7     
- Misses      16741    16748    +7     
+ Partials     6697     6688    -9
Files Coverage Δ
lib/internal/url.js 94.78% <100.00%> (+0.01%) ⬆️

... and 24 files with indirect coverage changes

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60977/

RedYetiDev
RedYetiDev reviewed Aug 8, 2024
View reviewed changes
lib/internal/url.js Outdated Show resolved Hide resolved
@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61034/

@EarlyRiser42
Copy link
Contributor Author

It seems that the failed test test-net-write-fully-async-buffer.js is flaky according to #47428.

huseyinacacak-janea
huseyinacacak-janea reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@huseyinacacak-janea huseyinacacak-janea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/61054/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4dc1ae0 into nodejs:main Aug 12, 2024
55 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4dc1ae0

@EarlyRiser42 EarlyRiser42 deleted the issue-54261 branch August 12, 2024 23:51
targos pushed a commit that referenced this pull request Aug 14, 2024
@EarlyRiser42 @targos
url: modify pathToFileURL to handle extended UNC path
4e73ba9 
PR-URL: #54262
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Aug 14, 2024
@EarlyRiser42 @targos
url: modify pathToFileURL to handle extended UNC path
0bed600 
PR-URL: #54262
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedYetiDev RedYetiDev RedYetiDev left review comments

@huseyinacacak-janea huseyinacacak-janea huseyinacacak-janea left review comments

@jasnell jasnell jasnell approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. whatwg-url Issues and PRs related to the WHATWG URL implementation. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pathToFileURL function in url fails to handle \\?\UNC\ Prefix properly
7 participants
@EarlyRiser42 @nodejs-github-bot @jasnell @aduh95 @RedYetiDev @huseyinacacak-janea @daeyeon