Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: use validateOneOf for colorMode validation #54245

Merged
merged 2 commits into from
Aug 10, 2024
Merged

console: use validateOneOf for colorMode validation #54245

merged 2 commits into from
Aug 10, 2024

Conversation

rayark1
Copy link
Contributor

@rayark1 rayark1 commented Aug 7, 2024

refactor the Console constructor to use validateOneOf for validating the colorMode parameter.

@rayark1
console: use validateOneOf for colorMode validation
553ffeb 
refactor the Console constructor to use validateOneOf for validating
the colorMode parameter.
@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. needs-ci PRs that need a full CI run. labels Aug 7, 2024
@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 7, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60933/

@codecov Codecov
Copy link

codecov bot commented Aug 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (e0634f5) to head (621df44).
Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54245      +/-   ##
==========================================
- Coverage   87.10%   87.10%   -0.01%     
==========================================
  Files         647      647              
  Lines      181739   181738       -1     
  Branches    34887    34885       -2     
==========================================
- Hits       158310   158298      -12     
- Misses      16738    16739       +1     
- Partials     6691     6701      +10
Files Coverage Δ
lib/internal/console/constructor.js 99.85% <100.00%> (-0.01%) ⬇️

... and 25 files with indirect coverage changes

@jakecastelli jakecastelli added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60958/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60965/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60970/

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 8, 2024
@cola119 cola119 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Aug 10, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2024
@nodejs-github-bot nodejs-github-bot merged commit 90d91ab into nodejs:main Aug 10, 2024
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 90d91ab

targos pushed a commit that referenced this pull request Aug 14, 2024
@rayark1 @targos
console: use validateOneOf for colorMode validation
e71390e 
refactor the Console constructor to use validateOneOf for validating
the colorMode parameter.

PR-URL: #54245
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit that referenced this pull request Aug 14, 2024
@rayark1 @targos
console: use validateOneOf for colorMode validation
37960a6 
refactor the Console constructor to use validateOneOf for validating
the colorMode parameter.

PR-URL: #54245
Reviewed-By: Kohei Ueno <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

@cola119 cola119 cola119 approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@rayark1 @nodejs-github-bot @lpinca @anonrig @tniessen @cola119 @jakecastelli