module: refactor ts parser loading #54243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
module
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54243 +/- ##
=======================================
Coverage 87.10% 87.11%
=======================================
Files 647 647
Lines 181739 181758 +19
Branches 34887 34887
=======================================
+ Hits 158310 158332 +22
- Misses 16738 16740 +2
+ Partials 6691 6686 -5
|
aduh95
approved these changes
Aug 7, 2024
github-actions
bot
removed
the
request-ci
marco-ippolito
added
the
author ready
|
The new function is not exposed as a public function or being able to be used with |
it's currently unusable from outside, but it prepares for it eventually |
legendecas
approved these changes
Aug 7, 2024
bnb
approved these changes
Aug 7, 2024
jakecastelli
approved these changes
Aug 8, 2024
marco-ippolito
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 3cbeed8 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54243 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the way TypeScript parser is loaded.
Currently the function
loadTypeScriptParseris not exposed but could allow overriding the default parsing options, so that an external version of amaro could be used.It also changes the
parsesignature to take only the code string input and return{ code }.