-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: improve async_context_frame structure #54239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
added
doc
Issues and PRs related to the documentations.
diag-agenda
Issues and PRs to discuss during the meetings of the diagnostics working group.
async_local_storage
AsyncLocalStorage
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Aug 7, 2024
nodejs-github-bot
added
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Aug 7, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2024
Qard
force-pushed
the
als-rewrite-followup
branch
from
August 7, 2024 02:40
57238f0
to
185ec61
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54239 +/- ##
==========================================
- Coverage 87.09% 87.09% -0.01%
==========================================
Files 647 647
Lines 181836 181778 -58
Branches 34917 34882 -35
==========================================
- Hits 158376 158320 -56
- Misses 16743 16766 +23
+ Partials 6717 6692 -25
|
Qard
force-pushed
the
als-rewrite-followup
branch
from
August 7, 2024 05:16
185ec61
to
cb6d5e6
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 7, 2024
Flarna
reviewed
Aug 8, 2024
Flarna
reviewed
Aug 8, 2024
Qard
force-pushed
the
als-rewrite-followup
branch
from
August 8, 2024 20:45
cb6d5e6
to
604d429
Compare
Flarna
approved these changes
Aug 8, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Aug 8, 2024
legendecas
approved these changes
Aug 9, 2024
Qard
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 9, 2024
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Aug 9, 2024
Landed in 7366808 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54239 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54239 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
targos
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
async_local_storage
AsyncLocalStorage
diag-agenda
Issues and PRs to discuss during the meetings of the diagnostics working group.
doc
Issues and PRs related to the documentations.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #48528 to deal with some unresolved feedback and to try a prototype-swap improvement to speed up AsyncResource performance a bit. Here's the benchmark numbers: