Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.x] Backport "module: fix strip-types interaction with detect-module" #54211

Conversation

marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Aug 5, 2024

This is a backport of #54164

This backport adds the imply of --experimental-detect-module to --experimental-strip-types
https://github.com/nodejs/node/pull/54211/files#diff-d0b7433f8ca620eba56fc39f79429c73e2b3f061ca6d27583132a37b788b8aa8R803

cc @joyeecheung

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Aug 5, 2024
@marco-ippolito marco-ippolito added needs-ci PRs that need a full CI run. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 5, 2024
@marco-ippolito marco-ippolito mentioned this pull request Aug 5, 2024
@marco-ippolito marco-ippolito added lib / src Issues and PRs related to general changes in the lib or src directory. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 5, 2024
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#54164
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
marco-ippolito added a commit that referenced this pull request Aug 5, 2024
PR-URL: #54164
Backport-PR-URL: #54211
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@marco-ippolito
Copy link
Member Author

Landed in c20e841

@marco-ippolito marco-ippolito deleted the backport/strip-types-imply branch August 5, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants