test: use assert.{s,deepS}trictEqual() #54208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `asset.strictEqual()` and `asset.deepStrictEqual()` in `test/parallel/test-tls-set-sigalgs.js`.
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
jakecastelli
approved these changes
Aug 5, 2024
daeyeon
approved these changes
Aug 5, 2024
daeyeon
added
author ready
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54208 +/- ##
=======================================
Coverage 87.09% 87.09%
=======================================
Files 647 647
Lines 181845 181845
Branches 34913 34913
=======================================
+ Hits 158373 158381 +8
Misses 16751 16751
+ Partials 6721 6713 -8 |
trivikr
approved these changes
Aug 5, 2024
benjamingr
approved these changes
Aug 5, 2024
anonrig
approved these changes
Aug 5, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in e0634f5 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
Use `asset.strictEqual()` and `asset.deepStrictEqual()` in `test/parallel/test-tls-set-sigalgs.js`. PR-URL: #54208 Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
Merged
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
asset.strictEqual()andasset.deepStrictEqual()intest/parallel/test-tls-set-sigalgs.js.