Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update buffer.constants.MAX_LENGTH size #54207

Merged

Conversation

samuliasmala
Copy link
Contributor

Starting from Node v22.0.0 (which uses V8 12.4) the buffer.constants.MAX_LENGTH has been increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14. If I read it right the change was done in this commit to V8 engine.

The change is also easy to verify manually:

Welcome to Node.js v21.7.3.
Type ".help" for more information.
> (require('buffer').constants.MAX_LENGTH) / 2**30
4

Welcome to Node.js v22.0.0.
Type ".help" for more information.
> (require('buffer').constants.MAX_LENGTH + 1) / 2**30
8388608
> (require('buffer').constants.MAX_LENGTH + 1) / 2**40
8192
>

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Aug 4, 2024
Starting from Node v22.0.0 the `buffer.constants.MAX_LENGTH` has been
increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14.
@samuliasmala
Copy link
Contributor Author

Updated the commit message to adhere 72 characters per line limit.

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2024
@nodejs-github-bot nodejs-github-bot merged commit 19bf154 into nodejs:main Aug 9, 2024
16 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 19bf154

targos pushed a commit that referenced this pull request Aug 14, 2024
Starting from Node v22.0.0 the `buffer.constants.MAX_LENGTH` has been
increased from 4 GiB to 8 PiB due to V8 engine update to 12.4.254.14.

PR-URL: #54207
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants