Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: remove force option as force defaults to true. #54203

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

debbs061
Copy link
Contributor

@debbs061 debbs061 commented Aug 4, 2024

Removed the force: true option as force defaults to true in the defaultCpOptions.

cc. @anonrig

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system. labels Aug 4, 2024
@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 4, 2024
@daeyeon daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit e1e7a41 into nodejs:main Aug 6, 2024
24 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e1e7a41

targos pushed a commit that referenced this pull request Aug 14, 2024
PR-URL: #54203
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants