Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update amaro to 0.0.6 #54199

Closed
wants to merge 2 commits into from
Closed

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Aug 4, 2024

This is an automated update of amaro to 0.0.6.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Aug 4, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 4, 2024
@nodejs-github-bot nodejs-github-bot changed the title deps: update amaro to 0.0.5 deps: update amaro to 0.0.6 Aug 4, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 4, 2024
@nodejs-github-bot
Copy link
Collaborator Author

@marco-ippolito marco-ippolito added the strip-types Issues or PRs related to strip-types support label Aug 4, 2024
Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.09%. Comparing base (01cf9bc) to head (5f91e55).
Report is 548 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #54199      +/-   ##
==========================================
+ Coverage   87.07%   87.09%   +0.01%     
==========================================
  Files         643      647       +4     
  Lines      181583   181851     +268     
  Branches    34886    34921      +35     
==========================================
+ Hits       158114   158383     +269     
+ Misses      16751    16748       -3     
- Partials     6718     6720       +2     

see 64 files with indirect coverage changes

@nodejs-github-bot
Copy link
Collaborator Author

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 4, 2024
@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. fast-track PRs that do not need to wait for 48 hours to land. labels Aug 5, 2024
Copy link
Contributor

github-actions bot commented Aug 5, 2024

Fast-track has been requested by @marco-ippolito. Please 👍 to approve.

@marco-ippolito
Copy link
Member

fast tracking as Id like to include it on v22.6.0

@marco-ippolito marco-ippolito added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Aug 5, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 5, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Commit Queue failed
- Loading data for nodejs/node/pull/54199
✔  Done loading data for nodejs/node/pull/54199
----------------------------------- PR info ------------------------------------
Title      deps: update amaro to 0.0.6 (#54199)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-amaro -> nodejs:main
Labels     lib / src, fast-track, author ready, needs-ci, dependencies, commit-queue-rebase, strip-types
Commits    2
 - deps: update amaro to 0.0.5
 - deps: update amaro to 0.0.6
Committers 1
 - Node.js GitHub Bot <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54199
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54199
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 04 Aug 2024 00:30:47 GMT
   ✔  Approvals: 5
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54199#pullrequestreview-2217282080
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54199#pullrequestreview-2217417552
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/54199#pullrequestreview-2217492450
   ✔  - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54199#pullrequestreview-2217736580
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54199#pullrequestreview-2219225527
   ℹ  This PR is being fast-tracked
   ✘  GitHub CI is still running
   ℹ  Last Full PR CI on 2024-08-04T07:34:43Z: https://ci.nodejs.org/job/node-test-pull-request/60860/
- Querying data for job/node-test-pull-request/60860/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/10251306992

@marco-ippolito marco-ippolito removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 5, 2024
marco-ippolito pushed a commit that referenced this pull request Aug 5, 2024
PR-URL: #54199
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 5, 2024
PR-URL: #54199
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@marco-ippolito
Copy link
Member

Landed in bc6f895...b95eac5

@targos targos deleted the actions/tools-update-amaro branch August 5, 2024 15:22
marco-ippolito pushed a commit that referenced this pull request Aug 5, 2024
PR-URL: #54199
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Aug 5, 2024
PR-URL: #54199
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 5, 2024
@targos targos added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants