Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc net connection #54194

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

sendoru
Copy link
Contributor

@sendoru sendoru commented Aug 3, 2024

Fixes: #53792
As net.connect() is alias of net.createConnection() and all of the detailed descriptions are written in latter one, the net.connect() function example is moved to net.createConnection() section and the name of function in the example code is altered to net.createConnection().

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Aug 3, 2024
@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 4, 2024
@daeyeon daeyeon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit a5200da into nodejs:main Aug 5, 2024
29 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a5200da

targos pushed a commit that referenced this pull request Aug 14, 2024
Fixes: #53792
PR-URL: #54194
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Socket onread described on wrong function
7 participants