test: set test-structuredclone-jstransferable non-flaky #54115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
targos
approved these changes
Jul 30, 2024
StefanStojanovic
added
the
request-ci
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54115 +/- ##
==========================================
+ Coverage 87.04% 87.07% +0.02%
==========================================
Files 643 643
Lines 181589 181589
Branches 34883 34887 +4
==========================================
+ Hits 158072 158111 +39
+ Misses 16785 16753 -32
+ Partials 6732 6725 -7 |
lpinca
approved these changes
Jul 30, 2024
legendecas
approved these changes
Jul 31, 2024
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1f69085 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
Fixes: #50260 PR-URL: #54115 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pummel test
test-structuredclone-jstransferableseems to be no longer flaky on Windows. I'm checking CI test results in the CI occasionally and haven't seen it failing recently. In addition, I ran stress test (1000 runs) and saw no failures.Fixes: #50260