Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: add missing binding function writeFileUtf8() #54110

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

pluris
Copy link
Contributor

@pluris pluris commented Jul 29, 2024

writefileutf8() binding function was missing in fs.d.ts.

It is defined as follows:

registry->Register(WriteFileUtf8);

function writeFileUtf8(path: string, data: string, flag: number, mode: number): void;
function writeFileUtf8(fd: number, data: string, flag: number, mode: number): void;

@daeyeon daeyeon added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 30, 2024
@daeyeon daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 1, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/54110
✔  Done loading data for nodejs/node/pull/54110
----------------------------------- PR info ------------------------------------
Title      typings: add missing binding function `writeFileUtf8()` (#54110)
Author     Jungku Lee <[email protected]> (@pluris)
Branch     pluris:fix/add_writeutf8_typing -> nodejs:main
Labels     author ready, typings
Commits    2
 - typings: add missing binding function `writeFileUtf8()`
 - typings: fix alphabetical order
Committers 1
 - pluris <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54110
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54110
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 29 Jul 2024 23:43:15 GMT
   ✔  Approvals: 2
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/54110#pullrequestreview-2206358248
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54110#pullrequestreview-2206377662
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 54110
From https://github.com/nodejs/node
 * branch                  refs/pull/54110/merge -> FETCH_HEAD
✔  Fetched commits as 00c0644747a1..18855da5c4dd
--------------------------------------------------------------------------------
[main dfcdf7930b] typings: add missing binding function `writeFileUtf8()`
 Author: pluris <[email protected]>
 Date: Tue Jul 30 08:09:49 2024 +0900
 1 file changed, 1 insertion(+)
[main 42ad8071fc] typings: fix alphabetical order
 Author: pluris <[email protected]>
 Date: Tue Jul 30 09:20:32 2024 +0900
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
typings: add missing binding function writeFileUtf8()

PR-URL: #54110
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

[detached HEAD 0061e9d5ce] typings: add missing binding function writeFileUtf8()
Author: pluris <[email protected]>
Date: Tue Jul 30 08:09:49 2024 +0900
1 file changed, 1 insertion(+)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
typings: fix alphabetical order

PR-URL: #54110
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

[detached HEAD 7a18fba241] typings: fix alphabetical order
Author: pluris <[email protected]>
Date: Tue Jul 30 09:20:32 2024 +0900
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/10201801905

@daeyeon daeyeon added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 1, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit 8e1e3a8 into nodejs:main Aug 1, 2024
33 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8e1e3a8

targos pushed a commit that referenced this pull request Aug 14, 2024
PR-URL: #54110
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants