-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typings: add missing binding function writeFileUtf8()
#54110
typings: add missing binding function writeFileUtf8()
#54110
Conversation
Commit Queue failed- Loading data for nodejs/node/pull/54110 ✔ Done loading data for nodejs/node/pull/54110 ----------------------------------- PR info ------------------------------------ Title typings: add missing binding function `writeFileUtf8()` (#54110) Author Jungku Lee <[email protected]> (@pluris) Branch pluris:fix/add_writeutf8_typing -> nodejs:main Labels author ready, typings Commits 2 - typings: add missing binding function `writeFileUtf8()` - typings: fix alphabetical order Committers 1 - pluris <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54110 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54110 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 29 Jul 2024 23:43:15 GMT ✔ Approvals: 2 ✔ - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/54110#pullrequestreview-2206358248 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54110#pullrequestreview-2206377662 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 54110 From https://github.com/nodejs/node * branch refs/pull/54110/merge -> FETCH_HEAD ✔ Fetched commits as 00c0644747a1..18855da5c4dd -------------------------------------------------------------------------------- [main dfcdf7930b] typings: add missing binding function `writeFileUtf8()` Author: pluris <[email protected]> Date: Tue Jul 30 08:09:49 2024 +0900 1 file changed, 1 insertion(+) [main 42ad8071fc] typings: fix alphabetical order Author: pluris <[email protected]> Date: Tue Jul 30 09:20:32 2024 +0900 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/10201801905 |
Landed in 8e1e3a8 |
PR-URL: #54110 Reviewed-By: Daeyeon Jeong <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
writefileutf8()
binding function was missing infs.d.ts
.It is defined as follows:
node/src/node_file.cc
Line 3705 in 3c50297
node/typings/internalBinding/fs.d.ts
Lines 240 to 241 in 3c50297