watch: reload changes in contents of --env-file #54109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we watch and reload on env file changes. Ignore env file in parent process, so child process can reload current vars when we recreate it. Fixes: nodejs#54001
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Jul 30, 2024
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54109 +/- ##
=======================================
Coverage 87.07% 87.07%
=======================================
Files 643 643
Lines 181590 181576 -14
Branches 34886 34892 +6
=======================================
- Hits 158114 158109 -5
+ Misses 16755 16746 -9
Partials 6721 6721
|
|
Fixed linter issues. |
MoLow
approved these changes
Aug 2, 2024
github-actions
bot
removed
the
request-ci
|
none of those seem related |
MoLow
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a816688 |
|
Are there no |
|
@tniessen I am not sure what you mean? can you elaborate? |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
Make sure we watch and reload on env file changes. Ignore env file in parent process, so child process can reload current vars when we recreate it. Fixes: #54001 PR-URL: #54109 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure we watch and reload on env file changes.
Ignore env file in parent process, so child process can reload current vars when we recreate it.
Fixes: #54001
I've noticed now that it's probably a duplicate of #54033.
Feel free to close or reuse tests from here in the other PR if you plan on merging it.
It was a nice small bug to get feet wet with Node internals anyway. 👋