Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: faster integer argument check #54089

Merged
merged 1 commit into from
Jul 30, 2024
Merged

buffer: faster integer argument check #54089

merged 1 commit into from
Jul 30, 2024

Conversation

ronag
Copy link
Member

@ronag ronag commented Jul 28, 2024 

buffers/buffer-copy.js n=6000000 partial='true' bytes=0        ***     11.22 %       ±5.01% ±6.67% ±8.68%

@ronag
Copy link
Member Author

ronag commented Jul 28, 2024

@nodejs/buffer @nodejs/performance

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run. labels Jul 28, 2024
mcollina
mcollina approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60695/

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60699/

ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2024
@ronag
buffer: faster integer argument check
620155f 
PR-URL: nodejs#54089
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jul 29, 2024
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 29, 2024
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@ronag ronag requested a review from anonrig July 29, 2024 08:58
@ronag ronag removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Jul 29, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (01cf9bc) to head (d797180).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #54089      +/-   ##
==========================================
- Coverage   87.07%   87.06%   -0.01%     
==========================================
  Files         643      643              
  Lines      181583   181584       +1     
  Branches    34886    34886              
==========================================
- Hits       158114   158103      -11     
+ Misses      16751    16748       -3     
- Partials     6718     6733      +15
Files Coverage Δ
lib/buffer.js 96.42% <100.00%> (+<0.01%) ⬆️

... and 29 files with indirect coverage changes

ronag added a commit to nxtedition/node that referenced this pull request Jul 29, 2024
@ronag
buffer: faster integer argument check
97c523c 
PR-URL: nodejs#54089
@tniessen
Copy link
Member

The commit message has to be amended to comply with our guidelines (prefix: imperative verb) before this can land :)

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60727/

@H4ad H4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2024
@nodejs-github-bot nodejs-github-bot merged commit e7edcf3 into nodejs:main Jul 30, 2024
56 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e7edcf3

targos pushed a commit that referenced this pull request Aug 14, 2024
@ronag @targos
buffer: use faster integer argument check
019ebf0 
PR-URL: #54089
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Daniel Lemire <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wa-Nadoo wa-Nadoo wa-Nadoo left review comments

@mcollina mcollina mcollina approved these changes

@lemire lemire lemire approved these changes

@jasnell jasnell jasnell approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. buffer Issues and PRs related to the buffer subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.