buffer: faster type check

[ronag]

Also add support for any TypedArray as target.

buffers/buffer-copy.js n=6000000 partial='true' bytes=128          ***     50.28 %       ±4.26% ±5.68%  ±7.42%
buffers/buffer-copy.js n=6000000 partial='true' bytes=8            ***     45.58 %       ±4.53% ±6.04%  ±7.89%

[ronag]

@nodejs/performance @nodejs/buffer

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60696/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60700/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60711/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.07%. Comparing base (1e3a347) to head (2d75eba).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54088      +/-   ##
==========================================
- Coverage   87.07%   87.07%   -0.01%     
==========================================
  Files         643      643              
  Lines      181581   181582       +1     
  Branches    34891    34886       -5     
==========================================
- Hits       158115   158107       -8     
- Misses      16749    16758       +9     
  Partials     6717     6717              

Files	Coverage Δ
lib/buffer.js	96.42% <100.00%> (+<0.01%)	⬆️

... and 27 files with indirect coverage changes

[tniessen]

The commit message has to be amended to comply with our guidelines (prefix: imperative verb) before this can land :)

[tniessen]

Is this semver-minor since it changes the public API? In any case, I think it makes sense to document the change in behavior. I assume the right place is to add a changes: block here:

node/doc/api/buffer.md

Lines 1711 to 1715 in 269175b

	### `buf.copy(target[, targetStart[, sourceStart[, sourceEnd]]])`
	<!-- YAML
	added: v0.1.90
	-->

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60779/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60820/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/54088
✔  Done loading data for nodejs/node/pull/54088
----------------------------------- PR info ------------------------------------
Title      buffer: faster type check (#54088)
Author     Robert Nagy <[email protected]> (@ronag)
Branch     ronag:buffer.copy-check -> nodejs:main
Labels     buffer, author ready, needs-ci
Commits    1
 - buffer: faster type check
Committers 1
 - Robert Nagy <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/54088
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54088
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 28 Jul 2024 22:18:55 GMT
   ✔  Approvals: 4
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54088#pullrequestreview-2210972720
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54088#pullrequestreview-2204005543
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54088#pullrequestreview-2205608335
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54088#pullrequestreview-2206203933
   ⚠  This PR has conflicts that must be resolved
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-08-02T05:56:32Z: https://ci.nodejs.org/job/node-test-pull-request/60820/
- Querying data for job/node-test-pull-request/60820/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/10213732908

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60842/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60845/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/60846/

[nodejs-github-bot]

Landed in acbd0be